feat: improved permission handling for MapFormField #1228
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: improved permission handling for MapFormField
This PR enables a center to be defined while still requesting and gracefully handling a current location call (which prompts permission check). This is to allow user testing with the following workflow.
This might be temporary since in reality we probably don't need to ask for the user's location if we don't intend to actually use it.
Technical changes include:
How to Test
Try different permutations of permissions yes, no, ask, as well as providing and not providing a center in the notebook definition. Check it always respects the center provided, shows errors where appropriate, and notifications work.
Checklist